Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/v2 workspaces #96

Merged
merged 24 commits into from
Sep 25, 2023
Merged

Feat/v2 workspaces #96

merged 24 commits into from
Sep 25, 2023

Conversation

lfbrehm
Copy link
Member

@lfbrehm lfbrehm commented Sep 25, 2023 •
edited
Loading

Workspaces

  • Adds list, describe and delete requests for workspace templates
  • Adds description, endpoint_id and hook_id fields and removes key values from templates

Hooks

  • Adds more key-value based trigger types
  • Error messages for hook callbacks
  • Internal hooks as enums instead of generic non-describing key values
  • Hook descriptions
  • Hooks can now be defined with optional result objects (Datasets/Collections) where hooks can append/upload objects
  • Additional ListOwnedHooks request

lfbrehm and others added 17 commits September 19, 2023 11:02
@lfbrehm
Copy link
Member Author

lfbrehm commented Sep 25, 2023

New feature: Hooks can have multiple associated project_ids

das-Abroxas
das-Abroxas approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@das-Abroxas das-Abroxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some superficial comments that can be addressed before merge.

aruna/api/storage/services/v2/object_service.proto Outdated
@@ -234,6 +234,8 @@ message UpdateObjectRequest {
string dataset_id = 10;
}
repeated storage.models.v2.Hash hashes = 12;
// Force new object revision
bool forced_revision = 13;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think force_revision sounds better for a request field.

Suggested change
bool forced_revision = 13;
bool force_revision = 13;

aruna/api/storage/services/v2/workspace_service.proto Outdated
@@ -23,6 +22,42 @@ service WorkspaceService {
body : "*"
};
}
// ListWorkspaceTemplatesById
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation should be changed also.

Suggested change
// ListWorkspaceTemplatesById
// GetWorkspaceTemplate

St4NNi
St4NNi approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@St4NNi St4NNi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lfbrehm lfbrehm merged commit 72fe4f4 into main Sep 25, 2023
4 checks passed
@lfbrehm lfbrehm deleted the feat/v2_workspaces branch September 25, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@St4NNi St4NNi St4NNi approved these changes

@das-Abroxas das-Abroxas das-Abroxas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lfbrehm @St4NNi @das-Abroxas