Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add qt5-webengine and qt6-webengine with chromium page size fix #17

Closed
wants to merge 2 commits into from

Conversation

yuyichao
Copy link
Contributor

I was not able to find other backport of the chromium patch for qt5-webengine, qt6-webengine is similarly affected but I've not done the backport for that yet.

I'll try to push upstream but I'm not sure how long that'll take (either archlinuxarm or qt). I have a local build that has gone passed where this patch is used but isn't finished just yet (running -j2 since there's OOM on mba if there are too much parallel build...). I also put a similar package in archlinuxcn and the auto build should start around 0100 CST (in an hour an a half).

@Chainfire for the backport.

@yuyichao
Copy link
Contributor Author

My locally (chroot) compiled package works (finish building and shows a webpage when it'd previously error).

Though that's actually accidentally based on the upstream (x86) pkgbuild without the alarm build system patch. Let's see if the on-going buildbot build finishes.....

@yuyichao yuyichao changed the title Add qt5-webengine with chromium page size fix Add qt5-webengine and qt6-webengine with chromium page size fix Jul 21, 2022
@yuyichao
Copy link
Contributor Author

@yuyichao yuyichao force-pushed the qt5-webengine branch 2 times, most recently from a8b1501 to 9703b7b Compare July 22, 2022 01:42
@yuyichao
Copy link
Contributor Author

And it turns out that gwenview (kde image viewer) uses qtpdf that’s based on pdfium which bundles an older versions of the chromium memory allocator. This actually causes gwenview to crash on pdf files (including when loading previews) as oppose to the original webengine issue, which simply load a blank window but never crashes afaict.

I’ve updated the patches to fix that and confirmed that it fixes the gwenview crash for me. I’ve also reported these to both qt and pdfium upstream and updated the wiki with the links.

@yuyichao
Copy link
Contributor Author

Ping @marcan

@yuyichao
Copy link
Contributor Author

Should be fixed in archlinux arm repo now. archlinuxarm/PKGBUILDs#1928

@yuyichao yuyichao closed this Aug 21, 2022
@yuyichao yuyichao deleted the qt5-webengine branch August 22, 2022 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant