-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support AIC version 3 #364
base: main
Are you sure you want to change the base?
Conversation
Is the only relevant difference the MAX_DIE field width? Can't we just reuse all the rest of the code and make that conditional / part of the regs struct? |
Yes. So i could just add them to the struct and and make them -1, and we read the DT if they are -1. Then we could share 2/3 init entirely. I'm also not positive they changed the max width for real. Or they have bugs. The max number of dies is 2 on m3 max, so if we left the field as-is, and left a comment, it would not break anything for now, since it fits easily in the field. |
SGTM, let's go with that. I'm indifferent about the max dies thing, it's academic until a monster Mac Pro shows up (if ever), and that's guaranteed to need piles of code changes anyway. |
445aca8
to
0838950
Compare
This is a take at it. I'm gonna install it in a second and test it - i also noticed a kboot thing that needed to be updated for aic3 and added it. |
This still works :) |
e5575c9
to
1f72c5b
Compare
Small changes, mostly some offsts are now available in the DT, and a mask change. Signed-off-by: Daniel Berlin <[email protected]>
4f95305
to
95d67cf
Compare
Support new version of AIC used by M3