Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use thread_local for storing ThreadId" from vendored v8 #1

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

seanwentzel
Copy link
Member

@seanwentzel seanwentzel commented Jan 5, 2024

This allows fibers to find thread_ids

https://app.asana.com/0/1206246080647551/1206281938708349/f

Test plan:
it looks like the Github workflows on this PR are pretty good!

  • run fibers on linux with this build

@seanwentzel
Copy link
Member Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link

@anpatellll anpatellll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@seanwentzel seanwentzel merged commit 825d91a into v18 Jan 5, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants