Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache decorator was not caching individual blocks #9

Merged
merged 1 commit into from
Jan 5, 2016
Merged

Cache decorator was not caching individual blocks #9

merged 1 commit into from
Jan 5, 2016

Conversation

JulienTant
Copy link
Member

The cache key didn't contain an identifier, so always the first cached element was returned.

The cache key didn't contain an identifier, so always the first cached element was returned.
@@ -37,7 +37,7 @@ public function get($name)
{
return $this->cache
->tags($this->entityName, 'global')
->remember("{$this->locale}.{$this->entityName}.get", $this->cacheTime,
->remember("{$this->locale}.{$this->entityName}.get.{$name}", $this->cacheTime,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Opening parenthesis of a multi-line function call must be the last content on the line
  • Only one argument is allowed per line in a multi-line function call

nWidart added a commit that referenced this pull request Jan 5, 2016
Cache decorator was not caching individual blocks
@nWidart nWidart merged commit 1cb2625 into AsgardCms:master Jan 5, 2016
@nWidart
Copy link
Member

nWidart commented Jan 5, 2016

Thanks! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants