Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix/csv-format (#86) #87

Merged
merged 1 commit into from
Sep 9, 2024
Merged

hotfix/csv-format (#86) #87

merged 1 commit into from
Sep 9, 2024

Conversation

tjorvenK
Copy link
Collaborator

@tjorvenK tjorvenK commented Sep 9, 2024

  • fix(csv): add quoting and disabled trimming, fix test case cause more lines to test had been added to the testfile_en.csv

  • fix(csv): set target/source language correctly

  • fix(csv): changed option type from char to string

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Test update

Checklist:

  • My code follows the Code of Conduct
  • I have read the CONTRIBUTING document
  • My Pull Request is scoped to one topic
  • I have chosen develop as the target branch
  • I have used a separate branch with a descriptive name
  • I have squashed any insignificant commits
  • I have rebased my branch onto develop
  • I have included a descriptive commit message
  • I have verified that my changes do not have any negative impact on existing functionality

Code of Conduct

By submitting this Pull Request, you are agreeing to follow our Code of Conduct and contribute to a positive and inclusive community.

@RealLHI
hotfix/csv-format (#86)
89df2a9 
* fix(csv): add quoting and disabled trimming, fix test case cause more lines to test had been added to the testfile_en.csv

* fix(csv): set target/source language correctly

* fix(csv): changed option type from char to string
@tjorvenK tjorvenK added the prerelease Indicates that this pr creates a new prerelease label Sep 9, 2024
@tjorvenK tjorvenK merged commit ef55a6a into main Sep 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
prerelease Indicates that this pr creates a new prerelease
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjorvenK @RealLHI