Style pass #1
Style pass #1
Conversation
Standardized style. Fix a few factual and copy paste errors. Fix some formatting. Consistently use code blocks for literals. Use sentence case for all parameters. Avoid math symbols, prefer code-style >=.
| | |vec_int_type| **abs**\ (\ |vec_int_type| x) | ||
| |vec_type| **abs**\ (\ |vec_type| x) | ||
|
|
||
| .. rst-class:: classref-method |
There was a problem hiding this comment.
This notation is considerably more verbose than my original using the bars and I can't see any difference in the rendered HTML. Any particular reason why we need to change it?
There was a problem hiding this comment.
That's weird! When I built it locally, I noticed two problems with how it rendered the overloaded function entries:
- The function names did not appear as white, but as gray.
- The wrapping was incorrect, so the return type of the function appeared at the end of the line.
I didn't get any screenshots, though. I'm going to rebuild and get some screenshots, then post a comment to the original PR so we don't fragment the review.
There was a problem hiding this comment.
Ok, tomorrow I can take some screenshots from my computer too if that would help
There was a problem hiding this comment.
Yeah, if both ways render identically for you, this might be something platform dependent. You should test on clamp, textureGrad, or textureProjGrad. For context, for me these look like this with this PR applied, on a 1080 screen, Firefox, Windows 10, 100% zoom in browser:
Standardized style.
Fix a few factual and copy paste errors.
Fix some formatting.
Consistently use code blocks for literals.
Use sentence case for all parameters.
Avoid math symbols, prefer code-style >=.