EmuHawk: SharpCompress implementation for Mono #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested and working on Mono (using zip and 7zip archives)
|
|
Looks like this also fixes the Virtu (appleII) issue. The core is now detected properly (although I dont have the necessary firmware on my ubuntu box at the moment):
|
43 tasks
YoshiRulz
approved these changes
Jan 14, 2019
| @@ -44,7 +44,8 @@ public bool CheckSignature(string fileName, out int offset, out bool isExecutabl | |||
| catch { } | |||
| finally | |||
| { | |||
| arcTest.Dispose(); | |||
| if (arcTest != null) | |||
There was a problem hiding this comment.
Pretty sure this can be arcTest?.Dispose();. Other than that, I dunno, if it works it works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge yet.Ready to merge once @YoshiRulz agrees.
I have built and tested on windows and mono (see results below).