Fail early when a top level statement fails to resolve #1202
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1165
There's more context in the issue itself. Basically we could fail to compile a global top level statement, and we would just keep going compiling the next statement. This caused an assertion failure.
This PR makes the compileTopLevelStatement return a boolean to indicate that it has failed to compile, which is then used to halt compilation early and show an error message. The advantage of this approach is that we don't run into assertion failures later on, and instead show an error that is descriptive to the user.
Example
On master we get:
With this branch we get: