Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect absolute output paths #1217

Merged
merged 4 commits into from
Apr 12, 2020
Merged

Conversation

surma
Copy link
Contributor

@surma surma commented Apr 12, 2020

I wanted to test #1216, but it turned out it was a bit more complicated. Thought I’d get my hands dirty rather than stretching this out any further. Hope you don’t mind, @MaxGraey.

Fixes #1215

@MaxGraey
Copy link
Member

You should add yourself to NOTICE file

@dcodeIO
Copy link
Member

dcodeIO commented Apr 12, 2020

Guess who immediately anticipated having to fix CI again

@surma
Copy link
Contributor Author

surma commented Apr 12, 2020

😅 done

Copy link
Member

@dcodeIO dcodeIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the very serious bureaucracy problem where you give us some of your data so we can name you in our frequent legal activities has been corrected, LGTM.

@surma
Copy link
Contributor Author

surma commented Apr 12, 2020

Looking forward to make lawsuits part of my regular schedule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

asc does not respect absolute output paths
3 participants