Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interfaces, Abstract Methods, and Virtual Overloading #862

Closed
wants to merge 52 commits into from
Closed
Show file tree
Hide file tree
Changes from 49 commits
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
7ce5709
temp
willemneal Sep 14, 2019
08f6dfe
compiles
willemneal Sep 18, 2019
6b58579
Works but virtual table is hard coded
willemneal Sep 20, 2019
f704437
Added relooper table and if cases
willemneal Sep 22, 2019
3864d7e
Fixed tests
willemneal Sep 22, 2019
2904951
Update arrayEquals
willemneal Sep 22, 2019
e09ce14
Test email again
Sep 23, 2019
e58342f
Adding Email to Notice to pass test
willemneal Sep 23, 2019
2a17582
Add test for structurally interface
willemneal Sep 23, 2019
a3aef9c
Improve type checking
willemneal Sep 23, 2019
99403b8
Added error messages
willemneal Sep 23, 2019
21c0227
Reduce number of unreachable instructions
willemneal Sep 23, 2019
e5d198c
remove file [skip ci]
willemneal Sep 23, 2019
5fb758f
Remove map and iterator usage
willemneal Sep 23, 2019
839aa13
Type checking improved, but virtual table needs work
Oct 1, 2019
099cb11
Better type checking and virtual table works
Oct 1, 2019
712d400
Add from to portable definition
Oct 2, 2019
45ba24d
Merge remote-tracking branch 'AssemblyScript/master' into virtual
Nov 22, 2019
b7e592b
Added Properties and Fields
Dec 2, 2019
694d77e
Removed virtual table function
Dec 2, 2019
6c29e9c
Fixed fail test
Dec 4, 2019
932d8ac
Add global getter example.
Dec 4, 2019
bec5f7c
Can handle setters
Dec 4, 2019
125aff0
Merge remote-tracking branch 'AssemblyScript/master' into virtual
Dec 4, 2019
cb4bcae
Add array.form
Dec 5, 2019
4c3bad9
Updated test artifacts
Dec 5, 2019
9f4c24b
Add Map Iterator
Dec 6, 2019
99721db
Added inheritance
Dec 6, 2019
3c813b3
Simplified and improved Inheritance
Dec 8, 2019
c2f72bd
Remove unneeded methods
Dec 8, 2019
178a3fd
Merge remote-tracking branch 'AssemblyScript/master' into virtual
Dec 9, 2019
7992d02
fix tests
Dec 9, 2019
88db597
Added Abstract Methods
Dec 9, 2019
b9debc4
fix uint8constructor issue
Dec 9, 2019
54e35d9
remove unneeded methods
Dec 9, 2019
3e36c26
Moved to branch table
Dec 9, 2019
43d9430
Added abstract SubClass to abstract method test
Dec 9, 2019
7e904a5
[skip ci] remove unused methods
Dec 9, 2019
de3d6ad
More clean up
Dec 9, 2019
34dba5d
Added Virtual Decorator for methods
Dec 11, 2019
516324d
Added more virtual overloading tests
Dec 11, 2019
57f6a05
update wat files
Dec 11, 2019
f837726
Added virtual decorator to index.d.ts
Dec 11, 2019
04e9672
Apparently removing comments changed the binary?
Dec 11, 2019
f65e9c5
Methods are virtual by default
Dec 12, 2019
a549360
pass linter
Dec 12, 2019
767124a
nits
Dec 12, 2019
9111134
Updates to iterators and map/set/array.from
Dec 13, 2019
104a573
Make Map/Set Iterable
Dec 13, 2019
2f58363
addresses nitpicks
Dec 18, 2019
cc965e3
merge passes tests
Jan 12, 2020
d5acd41
Merge with master
Jan 17, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion NOTICE
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ under the licensing terms detailed in LICENSE:
* Joshua Tenner <[email protected]>
* Nidin Vinayakan <[email protected]>
* Aaron Turner <[email protected]>
* Willem Wyndham <[email protected]>
willemneal marked this conversation as resolved.
Show resolved Hide resolved
* Willem Wyndham <[email protected]> or <[email protected]>
* Bowen Wang <[email protected]>
* Emil Laine <[email protected]>
* Stephen Paul Weber <[email protected]>
Expand Down
30 changes: 27 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion src/ast.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1174,7 +1174,8 @@ export enum DecoratorKind {
EXTERNAL,
BUILTIN,
LAZY,
UNSAFE
UNSAFE,
FINAL,
}

export namespace DecoratorKind {
Expand Down Expand Up @@ -1219,6 +1220,10 @@ export namespace DecoratorKind {
if (nameStr == "unsafe") return DecoratorKind.UNSAFE;
break;
}
case CharCode.f: {
if (nameStr == "final") return DecoratorKind.FINAL;
break;
}
}
} else if (
nameNode.kind == NodeKind.PROPERTYACCESS &&
Expand Down
Loading