-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update wabt to fix wabt.js not working in strict mode #43
update wabt to fix wabt.js not working in strict mode #43
Conversation
@dcodeIO To fix some bugs in wabt, a new version wabt need to be integrated. But the CI of this repo hasn't run for long time. Is this possible to reopen the CI and publish a new version to npm? |
I guess the workflow has been automatically disabled quite a while ago, probably due to upstream changes not resulting in any changes to the build artifacts. Triggered the workflow manually now, let's see how that goes. If it works, we could merge just the changes to build.yml of this PR. |
Hrm, seems there are errors upstream preventing the build from completing (see). If I'm not mistaken, there were some Emscripten changes a while ago also involving the removal of Two possible paths:
|
@dcodeIO Thank you very much! It's the reason why I want to update wabt here. By merging this PR, the build pipeline should work again. |
c4dde40
to
2467f89
Compare
The CI resets the wabt commit ID to lastest tag, which is 1.0.34 now. But the |
Iirc the code to determine the version to build lives around here: Lines 43 to 46 in 7279658
I guess we could either exclude the specific version, create a dummy tag in this repo, or wait for a new release upstream? |
We can wait for a new release upstream. |
No upstream release yet, but I fixed it otherwise. |
No description provided.