Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update wabt to fix wabt.js not working in strict mode #43

Closed

Conversation

Changqing-JING
Copy link

No description provided.

@Changqing-JING
Copy link
Author

@dcodeIO To fix some bugs in wabt, a new version wabt need to be integrated. But the CI of this repo hasn't run for long time. Is this possible to reopen the CI and publish a new version to npm?

@dcodeIO
Copy link
Member

dcodeIO commented Jan 22, 2024

I guess the workflow has been automatically disabled quite a while ago, probably due to upstream changes not resulting in any changes to the build artifacts. Triggered the workflow manually now, let's see how that goes. If it works, we could merge just the changes to build.yml of this PR.

@dcodeIO
Copy link
Member

dcodeIO commented Jan 22, 2024

Hrm, seems there are errors upstream preventing the build from completing (see). If I'm not mistaken, there were some Emscripten changes a while ago also involving the removal of writeAsciiToMemory, and it looks like these changes haven't been addressed by the upstream repo yet, hence failing this repo's sanity tests.

Two possible paths:

  • Fix the upstream bindings, which I'd prefer
  • If not possible, downgrade Emscripten to the last known working version here

@Changqing-JING
Copy link
Author

Changqing-JING commented Jan 23, 2024

@dcodeIO Thank you very much!
This PR can fix the writeAsciiToMemory error. The writeAsciiToMemory is not removed, but it's not exported by default in new version emcc.
I have already fixed this bug in wabt by adding option in cmake file:
WebAssembly/wabt#2367

It's the reason why I want to update wabt here.

By merging this PR, the build pipeline should work again.

@Changqing-JING
Copy link
Author

The CI resets the wabt commit ID to lastest tag, which is 1.0.34 now. But the writeAsciiToMemory is not integrated in 1.0.34.
Shall we wait for next wabt release tag and rerun the CI?

@dcodeIO
Copy link
Member

dcodeIO commented Jan 23, 2024

Iirc the code to determine the version to build lives around here:

if (semver.gt(src.version, dst.version))
console.log(src.version);
else
console.log(src.version + "-nightly." + dateFormat(Date.UTC(), "yyyymmdd"));

I guess we could either exclude the specific version, create a dummy tag in this repo, or wait for a new release upstream?

@Changqing-JING
Copy link
Author

We can wait for a new release upstream.

@dcodeIO dcodeIO closed this May 9, 2024
@dcodeIO
Copy link
Member

dcodeIO commented May 9, 2024

No upstream release yet, but I fixed it otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants