-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update astropy version #418
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #418 +/- ##
=======================================
Coverage 74.83% 74.83%
=======================================
Files 56 56
Lines 7824 7824
=======================================
Hits 5855 5855
Misses 1969 1969 ☔ View full report in Codecov by Sentry. |
What did you do to update the lock file? We should document that somewhere |
I thought I'd written that down somewhere before, but couldn't find it. Maybe I'll add it here. |
Running the poetry commands mentioned above gave me the following: This is a result of an over-enthusiastic dependabot in #417. The same PR is now also in some of our other projects. Please don't merge those, or they'll result in the same issue. I'll resolve them. To fix the warning here, I simply ran |
I've created AstarVienna/astarvienna.github.io#4 based on your instructions in #418 (comment) @teutoburg, thanks. About this specific issue: the |
Are we sure nothing breaks with Astropy 6.x? If yes, we could change it to ">= 5.3.4, < 7.0". |
We tested the latest dependencies before switching to poetry and using the caret notation, exactly so we would know early through the CI whether something would break. To me it seems worthwhile to add such a test back, because I want to prevent learning about things breaking when we don't have time for it. E.g. say that there would not have been an astropy 5.3.4, and we would have needed to switch to 6.x.y. If ScopeSim would not work with 6.x.y, then we would suddenly have no working version of ScopeSim anymore. |
Hmm I tried a simple
then manually set the Python version back to
But that still put only astropy 5.3.4 as a dependency. Which makes sense, because we specify So we can only do such a test properly by doing such a sed replace in all our projects... |
I've created AstarVienna/ScopeSim_Data#16 as an attempt to create a test that uses the actual latest dependencies. We can discuss the dependencies there further |
See
distutils.dep_util
throughsetuptools.modified
pypa/setuptools#4069@teutoburg I'm not sure about the process for using
poetry lock
. Should I first manually change all the=^
to==
inpyproject.toml
?