Do not ignore PytestRemovedIn8Warning. #420
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main point of treating warnings as errors in the tests is to detect deprecation warningns early, so we have time to fix them before they become errors.
We should only ignore deprecation warnings in very specific cases where we have ensured that doing so is save and will not cause problems.
At the very least, every ignored deprecation warning should come with an issue that describes what is required to fix the problem.