Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .Net Standard support #90

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Add .Net Standard support #90

wants to merge 14 commits into from

Conversation

Astn
Copy link
Owner

@Astn Astn commented Jan 6, 2018

This is for issue #89

Todo

Feel free to provide a pull request into this branch for any of the below.

  • Create AustinHarris.JsonRpc.Standard - Targets .Net Standard 2.0
  • Create TestServer_Console.Core - Targets .Net Core 2.0
  • Decouple main library from Json.Net and allow serialization to be injected.
  • Provide examples of getting setup with Json.net
  • Provide examples of getting setup with some alternative (Suggestions?)
  • Figure out the Nuget situation
  • Determine if we can target a lower version of .Net Standard or if it isn't worth the effort

@bonesoul
Copy link
Collaborator

bonesoul commented Jan 6, 2018

great work 👍

@Astn
Copy link
Owner Author

Astn commented Jan 23, 2018

Initial tests on my Ubuntu 17 workstation are looking promising.

  • E5-1650 v4 @ 3.60GHz
  • 64 GB Mem

During this run cpu topped out at ~ 50% cpu utilization. So there should still be some improvements that can be done.

Starting benchmark
processed 50 rpc in 2ms for 25000 rpc/sec
processed 100 rpc in 0ms for ∞ rpc/sec
processed 300 rpc in 0ms for ∞ rpc/sec
processed 1200 rpc in 4ms for 300000 rpc/sec
processed 6000 rpc in 28ms for 214285.714285714 rpc/sec
processed 36000 rpc in 162ms for 222222.222222222 rpc/sec
processed 252000 rpc in 798ms for 315789.473684211 rpc/sec
processed 2016000 rpc in 4912ms for 410423.45276873 rpc/sec
Finished benchmark...
Hit Enter to run benchmark
'c' to start reading console input
'q' to quit

@Astn Astn self-assigned this Jun 7, 2018
@Astn Astn mentioned this pull request Nov 15, 2018
@haakoo
Copy link

haakoo commented May 2, 2019

Any progress or time frame on this issue?

I'm building a .Net Core app (/service) and need to support clean JSON RPC (no headers), and would like to use a library and not roll my own.

@Astn
Copy link
Owner Author

Astn commented May 3, 2019

Any progress or time frame on this issue?

I'm building a .Net Core app (/service) and need to support clean JSON RPC (no headers), and would like to use a library and not roll my own.

Nothing recently. I could use a little help reviewing the code, and feedback on if it's ready a beta release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants