Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cord-nvim's build script fails on windows #1136

Closed
4 tasks done
Std-Enigma opened this issue Jul 28, 2024 · 7 comments · Fixed by #1137 or #1134
Closed
4 tasks done

cord-nvim's build script fails on windows #1136

Std-Enigma opened this issue Jul 28, 2024 · 7 comments · Fixed by #1137 or #1134
Labels
bug Something isn't working

Comments

@Std-Enigma
Copy link
Contributor

Std-Enigma commented Jul 28, 2024

Checklist

  • I have searched through the AstroNvim documentation
  • I have searched through the existing issues of this project
  • I have searched the existing issues of plugins related to this issue
  • I can replicate the bug with the minimal repro.lua provided below

Neovim version (nvim -v)

0.10.0 release

Operating system/version

Windows 11

Terminal/GUI

neovide

Describe the bug

This is error is probably caused by the fact that / paths aren't valid on windows cmd

Steps to Reproduce

  1. Open neovim on (wnidows)
  2. run :Lazy build cord.nvim

Expected behavior

Successful build.

Screenshots

No response

Additional Context

Here is the error:

[cord.nvim] Could not find the compiled dynamic library at: %LOCALAPPDATA%/nvim-data/lazy/cord.nvim/cord.dll. Please re-run the build script

Minimal configuration

-- save as repro.lua
-- run with nvim -u repro.lua
-- DO NOT change the paths
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "runtime", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

local lazypath = vim.fn.stdpath "data" .. "/lazy/lazy.nvim"
if not (vim.uv or vim.loop).fs_stat(lazypath) then
  -- stylua: ignore
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", "--branch=stable", lazypath })
end
vim.opt.rtp:prepend(lazypath)

require("lazy").setup {
  { "AstroNvim/AstroNvim", import = "astronvim.plugins" },
  { "AstroNvim/astrocommunity", { import = "astrocommunity.media.cord-nvim" } },
}
@Std-Enigma Std-Enigma added the bug Something isn't working label Jul 28, 2024
@Uzaaft
Copy link
Member

Uzaaft commented Jul 28, 2024

Do you get any output that shows you that the build command is failing?

@Uzaaft
Copy link
Member

Uzaaft commented Jul 28, 2024

Your error message could be interpreted as rust not being available, since the lib isn't available.

Std-Enigma added a commit to Std-Enigma/astrocommunity that referenced this issue Jul 28, 2024
@Std-Enigma
Copy link
Contributor Author

that would make sense but just checked the cord.nvim repo and it mentioned in the note the path should differ on windows machine I'll open a PR

@Uzaaft
Copy link
Member

Uzaaft commented Jul 28, 2024

It doesn't say should. It says "you MAY need to use a backslash as the path seperator".
We should first make sure the issue is not your setup or missing requirements, before we do changes.

@Std-Enigma
Copy link
Contributor Author

okay let me test a few things

@Std-Enigma
Copy link
Contributor Author

'.' is not recognized as an internal or external command, operable program or batch file.
This is the error lazy showed as the build status, i dug a little bit further this script should generate two files which are cord.dll.expand cord.dll.lib but when the path is specified as ./build in plugin spec i get this error but when specified like .\\build this isn't the case

@Uzaaft
Copy link
Member

Uzaaft commented Jul 28, 2024

Nice. I'd appreciate it if you included that into the initial bug report next time. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants