-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vue): configure volar as tsserver plugin #1007
feat(vue): configure volar as tsserver plugin #1007
Conversation
Review ChecklistDoes this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist: Proper conventional commit scoping:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems alright on a first glance. What do you think our in-house LSP expert? @mehalter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested this to make sure it works? Do we also need to reenable hybrid mode for volar?
Idk anything about this process but the code looks fine. I saw we just merge it if the user says they have actually tested it.
I tested it on three projects and it worked as expected. Enable hybrid mode works at first glance, but causes duplications in cmp entries and strange behavior in TS projects that don't use Vue. |
Ok cool! Then looks good to me! |
📑 Description
Add Volar as a tsserver plugin, configured with vtsls.
ℹ Additional Information
In
volar >= 2.0
, some synchronization problems between tsserver and volar appear, causing errors when working with .ts and .vue files at the same time.An issue for this is being tracked (yioneko/vtsls#148)