Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vue): configure volar as tsserver plugin #1007

Merged
merged 1 commit into from
May 30, 2024

Conversation

gabrielscaranello
Copy link
Contributor

📑 Description

Add Volar as a tsserver plugin, configured with vtsls.

ℹ Additional Information

In volar >= 2.0, some synchronization problems between tsserver and volar appear, causing errors when working with .ts and .vue files at the same time.

An issue for this is being tracked (yioneko/vtsls#148)

Copy link

github-actions bot commented May 29, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@gabrielscaranello gabrielscaranello marked this pull request as ready for review May 29, 2024 20:55
Copy link
Member

@Uzaaft Uzaaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems alright on a first glance. What do you think our in-house LSP expert? @mehalter

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested this to make sure it works? Do we also need to reenable hybrid mode for volar?

Idk anything about this process but the code looks fine. I saw we just merge it if the user says they have actually tested it.

@gabrielscaranello
Copy link
Contributor Author

Have you tested this to make sure it works? Do we also need to reenable hybrid mode for volar?

Idk anything about this process but the code looks fine. I saw we just merge it if the user says they have actually tested it.

I tested it on three projects and it worked as expected. Enable hybrid mode works at first glance, but causes duplications in cmp entries and strange behavior in TS projects that don't use Vue.

@mehalter
Copy link
Member

Ok cool! Then looks good to me! :shipit:

@mehalter mehalter merged commit 4b149f1 into AstroNvim:main May 30, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants