Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pack): add hyprland config file language support #1063

Merged
merged 8 commits into from
Jun 21, 2024

Conversation

WilliamBy
Copy link
Contributor

📑 Description

ℹ Additional Information

Copy link

github-actions bot commented Jun 21, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@mehalter
Copy link
Member

mehalter commented Jun 21, 2024

We should hold off until this PR is merged: williamboman/mason-lspconfig.nvim#428

If we get the changes I requested merged in, I can always just do a follow up PR to simplify this once the mason-lspconfig PR is merged

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few fixes/improvements

lua/astrocommunity/pack/hyprland/init.lua Outdated Show resolved Hide resolved
lua/astrocommunity/pack/hyprland/init.lua Outdated Show resolved Hide resolved
lua/astrocommunity/pack/hyprland/init.lua Show resolved Hide resolved
@mehalter
Copy link
Member

Once the PR to mason-lspconfig is merged we should simplify the AstroLSP configuration as well as add:

  {
    "williamboman/mason-lspconfig.nvim",
    optional = true,
    opts = function(_, opts)
      opts.ensure_installed = require("astrocore").list_insert_unique(opts.ensure_installed, { "hyprls" })
    end,
  },

@mehalter mehalter merged commit 78a0456 into AstroNvim:main Jun 21, 2024
12 checks passed
mehalter added a commit that referenced this pull request Jun 21, 2024
* feat(pack): add hyprland config file language support

* Update lua/astrocommunity/pack/hyprland/init.lua

Co-authored-by: Micah Halter <[email protected]>

* Update lua/astrocommunity/pack/hyprland/init.lua

Co-authored-by: Micah Halter <[email protected]>

* Update lua/astrocommunity/pack/hyprland/init.lua

Co-authored-by: Micah Halter <[email protected]>

* Update lua/astrocommunity/pack/hyprland/init.lua

Co-authored-by: Micah Halter <[email protected]>

* Update lua/astrocommunity/pack/hyprland/README.md

* Update lua/astrocommunity/pack/hyprland/README.md

* Update lua/astrocommunity/pack/hyprland/README.md

---------

Co-authored-by: Micah Halter <[email protected]>
@mehalter
Copy link
Member

Ok, I just did a follow up revision of this PR to rename this to hyprlang pack just because that is technically the name of the configuration language rather than hyprland

@mehalter
Copy link
Member

Thanks for the contribution! This is a great one! :D Love seeing packs getting added that really decrease setup like setting up filetypes and things 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants