Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pack): Fix dap debugging for typescript and javascript #160

Closed
wants to merge 2 commits into from
Closed

fix(pack): Fix dap debugging for typescript and javascript #160

wants to merge 2 commits into from

Conversation

Uzaaft
Copy link
Member

@Uzaaft Uzaaft commented Apr 24, 2023

This PR aims to finally make DAP debugging work with TS and JS.
Should Fix #148

@Uzaaft
Copy link
Member Author

Uzaaft commented Apr 24, 2023

Review? @owittek

@owittek
Copy link
Member

owittek commented Apr 24, 2023

image

I'm having unbound breakpoints & my DAP is not able to connect. My test project consists of a main.ts file with a few variable declarations & console.log statements.

@skriems
Copy link

skriems commented Apr 26, 2023

you may want to take a look at #163 @Uzaaft @owittek.

That reflects my working setup using vscode-js-debug.

@Uzaaft
Copy link
Member Author

Uzaaft commented Apr 26, 2023

you may want to take a look at #163 @Uzaaft @owittek.

That reflects my working setup using vscode-js-debug.

Might be a solution. I gues you'll need more feedback from @owittek .
It would require ts-node, which I personally am not a fan of. At least with deno, you can auto-install it.

@Uzaaft
Copy link
Member Author

Uzaaft commented Apr 26, 2023

Closing this PR. Let's work on #121 together.

@Uzaaft Uzaaft closed this Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DAP pack in astrocommunity.pack.typescript is missing typescript dap support
3 participants