Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(programming-language-support): Add xbase #671

Merged
merged 2 commits into from
Dec 6, 2023
Merged

feat(programming-language-support): Add xbase #671

merged 2 commits into from
Dec 6, 2023

Conversation

andreacfromtheapp
Copy link
Contributor

πŸ“‘ Description

Moving XBase to its own plugin as suggested by @Uzaaft . There is also a discussion about Swift/Xcode/Xbase/Xcodebuild here: #669

β„Ή Additional Information

This changes (moving XCode baed tools to plugins instead of Swift pack) would require to remove the current Swift pack or if acceptable merge an opinionated version (when it manage to fix it...): #670 -- I'm fine deleting it altogether if this is not adhering to community standards. I'm not agreeing on having a Swift pack with only treesitter in there...

Copy link

github-actions bot commented Dec 4, 2023

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@andreacfromtheapp
Copy link
Contributor Author

andreacfromtheapp commented Dec 4, 2023

ps: nvimcraft didn't have a fitting category. as per contributing documentation I came up with one. I'm open to ideas and changes.

@Uzaaft
Copy link
Member

Uzaaft commented Dec 5, 2023

We've got packs with only treesitter stuff, so that's not an issue tbh.

@andreacfromtheapp
Copy link
Contributor Author

We've got packs with only treesitter stuff, so that's not an issue tbh.

I see. Well, I'm not in a position to decide on this. I still don't really agree with that, but I guess that's what it is.

@Uzaaft
Copy link
Member

Uzaaft commented Dec 5, 2023

We've got packs with only treesitter stuff, so that's not an issue tbh.

I see. Well, I'm not in a position to decide on this. I still don't really agree with that, but I guess that's what it is.

It is what it is indeed.

I'll be going trough your PR later today.

@Uzaaft Uzaaft changed the title feat(xcode): Add XBase feat(programing-language-support): Add xbase Dec 5, 2023
@Uzaaft
Copy link
Member

Uzaaft commented Dec 5, 2023

@gacallea Moved the plugin to what I think is a more sensible folder.

@andreacfromtheapp
Copy link
Contributor Author

closes #669

@Uzaaft Uzaaft changed the title feat(programing-language-support): Add xbase feat(programming-language-support): Add xbase Dec 5, 2023
@Uzaaft Uzaaft merged commit e5ddf96 into AstroNvim:main Dec 6, 2023
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants