Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grapple-nvim)!: update to Grapple v0.10.0 #779

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

cbochs
Copy link
Contributor

@cbochs cbochs commented Mar 1, 2024

📑 Description

Hello! 👋

I thought I would get this PR ready. It should account for all changes made in the upcoming release (rewrite) of Grapple.nvim. Please don't merge until cbochs/grapple.nvim#89 is merged.

Copy link

github-actions bot commented Mar 1, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@cbochs cbochs changed the title fix(grapple): update after rewrite fix(grapple-nvim): update after rewrite Mar 1, 2024
Uzaaft
Uzaaft previously approved these changes Mar 1, 2024
@Uzaaft Uzaaft dismissed their stale review March 1, 2024 21:11

Question around if the PR is breaking change or ot

@mehalter mehalter changed the title fix(grapple-nvim): update after rewrite fix(grapple-nvim)!: update to Grapple v0.10.0 Mar 1, 2024
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mehalter
Copy link
Member

mehalter commented Mar 1, 2024

Thanks so much for helping us keep this up to date! Lots of people here love this plugin and will be very happy with the new version being supported so quickly!

@mehalter mehalter merged commit 30e8aae into AstroNvim:main Mar 1, 2024
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants