feat(pack/java): add Java Language Pack #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjcobb2022
changed the title
mehalter
requested changes
Mar 18, 2023
|
We can resolve the git commits history with squash/merge as well so no worries about that |
|
@mehalter Fixed! |
mehalter
requested changes
Mar 18, 2023
Yeh sorry I just used github to edit. |
|
Thanks so much @sjcobb2022 ! |
owittek
pushed a commit
to owittek/astrocommunity
that referenced
this pull request
Mar 25, 2023
* initial commit * debugging * attach jdtls * back to basics * setup debugging * parsing opts test * pass opts to start_or_attach * remove ft as test * add notif message * removed root_dir temporarily * use .project as a root marker for eclipse projects * added server * test jdtls without blocking * workspace dir notify * working... * forgot skip_setup * identified issue * try attaching ft * setup server * add autocmd * server config * manually add ft * don't provide cmd * view default settings * try lsp method * put test notify * back to old method * notify default config * only print messsage * default opts * list commands * default thing * try again * remove accidental changes * try with default config again * callbacks * It don't load plugin * rm ensure installed * attempt 2 * comment out for now * use setup handler? * don't block stopping * reformatting * reference self * add a dependency * use setup_handlers from mason-lspconfig * add to skip_setup again * verify attach with callback * change dependencies around * more comments * only necessary messages * remove ignore again * root_dir as string? * try require mason-lspconfig * skip jdtls setup * dump opts * if opts_ null * attach server * begin dependencies again * convert * print * not attaching correctly * dump opts * custom on_attach * lsp.opn_attach * removed dependencies from mason-lspconfiog * inspect server_capabilities * pass bufnr as well * add error log messages and fix os detection * fix floor in logic * add clang_format with null0ls * allow user extensibility * other way round * gen opts * return opts * inspect opts * insert unique print * wrap in table * print root_dir * inspect opts in config * opts * error with merge * list unique * test * test2 * deep extend * set opts * return opts again * functional * remove debug printing * cleanup and comments * try get java-debug-adapter install_path * try javadbg * javadbg does not work * added java-test * fix debug adapters * print bundles for debugging * reformat bundles * inline * add dap * don't pass func unto setup_dap * dap print * else * print test * notify * add util * setup dap before attach * setup_dap in autocmd * setup_dap_main_class_configs is required. use in autocmd * add to on_attach anyway * set autocmd for LspAttach * wrong function location * test options for placement * add autocmd into on_attach to access buff * insepct args buf * move attach again * remove err * add debugging * utilSSS * print proper * more debugging * try matching pattern properly * try printing name of buf * pattern list? * general pattern for ft * move to config * autocmd pos * Complete Debugging * ensure client is jdtls * add comments * update README * pass lint * use stylua
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #75
Hi There,
Spent a part of the week making the java pack. The commit tree is really messy as I was using a git reference to the package to test it (probs not the best idea).
The package adds quite a few things so I'll list them here
javatreesitter parsershtmltreesitter parsers (XML)jdtlslanguage serverlemminxlanguage server (XML)clang_formatthrough null-lsjavadbgandjavatestdebug adapters for nvim-dap