Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sql): drop sqlfluff as sqls supports formatting #890

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Conversation

mehalter
Copy link
Member

📑 Description

sqls supports formatting so we don't need to add sqlfluff.

ℹ Additional Information

Copy link

github-actions bot commented Apr 17, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@Uzaaft
Copy link
Member

Uzaaft commented Apr 17, 2024

@mehalter Technically, it's a linter. (I know, it's my mistake 😂)

@mehalter
Copy link
Member Author

It also provides formatting and it can conflict with the formatting of sqls. It also seems to mainly just be giving people problems rather than being particularly useful

@mehalter mehalter closed this Apr 17, 2024
@mehalter
Copy link
Member Author

we'll just leave it 🤷🏼

@mehalter mehalter deleted the drop_sqlfluff branch April 17, 2024 14:41
@Uzaaft Uzaaft restored the drop_sqlfluff branch April 17, 2024 17:21
@Uzaaft Uzaaft reopened this Apr 17, 2024
@mehalter mehalter requested a review from Uzaaft April 17, 2024 18:53
@Uzaaft Uzaaft merged commit 738444a into main Apr 17, 2024
22 checks passed
@Uzaaft Uzaaft deleted the drop_sqlfluff branch April 17, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants