Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugins): add harpoon support #101

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Conversation

trimclain
Copy link
Contributor

📑 Description

With recent changes it's now possible to change harpoon colors.
image

@A-Lamia
Copy link
Contributor

A-Lamia commented Dec 4, 2023

Interesting does harpoon not use default highlights ?

@trimclain
Copy link
Contributor Author

Interesting does harpoon not use default highlights ?

I was the one to add the highlights to harpoon and since I'm a little new to highlight groups in neovim, I didn't really know this is a thing. I might create a PR for this later

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@A-Lamia A-Lamia merged commit ee55f32 into AstroNvim:main Dec 4, 2023
9 checks passed
@A-Lamia
Copy link
Contributor

A-Lamia commented Dec 4, 2023

Interesting does harpoon not use default highlights ?

I was the one to add the highlights to harpoon and since I'm a little new to highlight groups in neovim, I didn't really know this is a thing. I might create a PR for this later

So typically when you are building a plugin you would use existing highlight groups if they fit what you want, in this case harpoon is just using a float window, so it was confusing why it's not just linking to the themes highlights groups :)

@trimclain
Copy link
Contributor Author

Interesting does harpoon not use default highlights ?

I was the one to add the highlights to harpoon and since I'm a little new to highlight groups in neovim, I didn't really know this is a thing. I might create a PR for this later

So typically when you are building a plugin you would use existing highlight groups if they fit what you want, in this case harpoon is just using a float window, so it was confusing why it's not just linking to the themes highlights groups :)

Thanks, I made the PR to harpoon and it got merged :)

@trimclain trimclain deleted the harpoon branch December 6, 2023 17:17
@mehalter
Copy link
Member

mehalter commented Dec 6, 2023

That's awesome! I'll make a commit to revert this in AstroTheme since we get it for free now :) Good to decrease the number of highlights we set since that operation is so slow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants