Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality: gdf_from_bbox. #15

Merged
merged 1 commit into from
Aug 4, 2020

Conversation

xgerrmann
Copy link

No description provided.

@xgerrmann
Copy link
Author

@AtelierLibre Would you like to take a look at this? It contains a functionality which I think will be useful.

@AtelierLibre
Copy link
Owner

@xgerrmann sorry, getting used to working across forks branches etc. I don't have a problem with pulling this in but I think @gboeing needs to comment as he has done a lot of work on tidying up the API and I think if this is to be included it would need to be implemented for the graph module as well.

@gboeing
Copy link

gboeing commented Aug 3, 2020

Thanks @xgerrmann.

@AtelierLibre an equivalent graph_from_bbox function already exists, so this would help make everything consistent. See here.

@AtelierLibre AtelierLibre merged commit 4ce20a9 into AtelierLibre:geometry Aug 4, 2020
@AtelierLibre
Copy link
Owner

@xgerrmann @gboeing Thanks, I have merged this in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants