Clean up compiler warnings for all platforms #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a number of compiler warnings in the current code. Let's get rid of them all. Add -Werror to prevent new compile warnings from creeping in
jt-traub
force-pushed
the
jt-clean-build-warnings
branch
from
a590535
to
a3a43db
Compare
valdisz
approved these changes
Oct 6, 2023
|
LGTM |
|
@valdisz sounds good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a number of compiler warnings in the current code. Let's
get rid of them all.
Add -Werror to prevent new compile warnings from creeping in