Generate test data #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finishes most of the subtask in #23 of generating sample data with a redacted copy.
The redacted IDs match the format of real IDs, so we'll end up with fake addon-license-ids like L64504661 and 89032315, fake transaction-ids like AT-646765546, and fake deal-ids like 5679651591.
The redacted combined-transaction-and-addon-license-ids are now redacted in parts, so they're not "unrelated" to existing IDs. So for example, for AT-646765546 and 89032315, we now print AT-646765546[89032315] whereas before this PR it was a random string that had nothing to do with either of those.
We now also print the Transaction/License IDs, deal stage, and amount, for deals that have no action taken on them. This will be useful for quickly seeing (and verifying) why the engine thought no action should be taken.
The code is more secure against typos that might accidentally print real data to the redacted output file, by creating the logger file and the redactor at the same time in a new class.