-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test suite #65
Merged
Merged
Test suite #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deal generator test engine.
…p in test generator.
…se sets which were hindering writing tests.
Closed
5 tasks
khanguyen88
approved these changes
Dec 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #62 and (potentially) finishes #23 to add integration tests.
After this PR, scenarios in
deal-generator.txt
will have IDs likeW1siMjQ1NDgyMiIsW11dXQ==
.Using these IDs, we can generate tests like this:
Which will print something like this, suitable for pasting into the test suite:
This only tests the deal-generation phase of the engine. But it is one of the most vital and complex parts of the engine, which is why this task focused on that. The only other big part of the engine we could test is the license matcher. That has so far only been tested with a combination of trial and error, and saving extreme amounts of logs, but it has been very thoroughly tested. It will be much harder to test on fake data than the deal generator, but it's probably still possible if/when we want to add tests for it.