fix: pagination & tab

Atnic · May 21, 2024 · df06b38 · df06b38
1 parent 3b4c926
commit df06b38
Show file tree

Hide file tree

Showing 8 changed files with 60 additions and 4 deletions.
diff --git a/packages/components/pagination/CHANGELOG.md b/packages/components/pagination/CHANGELOG.md
@@ -1,5 +1,29 @@
 # @jala-banyu/pagination
 
+## 1.1.38
+
+### Patch Changes
+
+- fix typo aria attribute
+
+## 1.1.37
+
+### Patch Changes
+
+- testing change role to aria-role
+
+## 1.1.36
+
+### Patch Changes
+
+- remove duplicated role on pagination
+
+## 1.1.35
+
+### Patch Changes
+
+- fixing accessibility
+
 ## 1.1.34
 
 ### Patch Changes

diff --git a/packages/components/pagination/package.json b/packages/components/pagination/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@jala-banyu/pagination",
-  "version": "1.1.34",
+  "version": "1.1.38",
   "description": "The Pagination component allows you to display active page and navigate between multiple pages.",
   "keywords": [
     "pagination"

diff --git a/packages/components/pagination/src/use-pagination-item.ts b/packages/components/pagination/src/use-pagination-item.ts
@@ -87,7 +87,8 @@ export function usePaginationItem(props: UsePaginationItemProps) {
   const getItemProps: PropGetter = (props = {}) => {
     return {
       ref: domRef,
-      role: "button",
+      "aria-role": "button",
+      // role: "button",
       tabIndex: isDisabled ? -1 : 0,
       "aria-label": ariaLabel,
       "aria-current": dataAttr(isActive),

diff --git a/packages/components/tabs/CHANGELOG.md b/packages/components/tabs/CHANGELOG.md
@@ -1,5 +1,11 @@
 # @jala-banyu/tabs
 
+## 1.1.4
+
+### Patch Changes
+
+- fixing accessibility
+
 ## 1.1.3
 
 ### Patch Changes

diff --git a/packages/components/tabs/package.json b/packages/components/tabs/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@jala-banyu/tabs",
-  "version": "1.1.3",
+  "version": "1.1.4",
   "description": "Tabs organize content into multiple sections and allow users to navigate between them.",
   "keywords": [
     "tabs"

diff --git a/packages/components/tabs/src/tab.tsx b/packages/components/tabs/src/tab.tsx
@@ -99,6 +99,7 @@ const Tab = forwardRef<"button", TabItemProps>((props, ref) => {
       data-pressed={dataAttr(isPressed)}
       data-selected={dataAttr(isSelected)}
       data-slot="tab"
+      role="button"
       {...mergeProps(
         tabProps,
         !isDisabled

diff --git a/packages/core/react/CHANGELOG.md b/packages/core/react/CHANGELOG.md
@@ -1,5 +1,29 @@
 # @jala-banyu/react
 
+## 1.3.10
+
+### Patch Changes
+
+- fix aria attribute
+
+## 1.3.9
+
+### Patch Changes
+
+- testing aria label pagination
+
+## 1.3.8
+
+### Patch Changes
+
+- update pagination
+
+## 1.3.7
+
+### Patch Changes
+
+- fix accesibility
+
 ## 1.3.6
 
 ### Patch Changes

diff --git a/packages/core/react/package.json b/packages/core/react/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@jala-banyu/react",
-  "version": "1.3.6",
+  "version": "1.3.10",
   "description": "Banyu core React UI library",
   "author": "Muhammad Amien <[email protected]>",
   "homepage": "#",