V3 #5
Open
V3 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a test to detect it and fix the bug. Fixes issue robfig#206
Test[Non]LocalTimezone was occasionally specifying an invalid cron spec seconds field of "59,60", which caused it to subsequently fail. Since rolling the cron spec forward is hard, in those cases we instead sleep for a couple seconds to avoid the scenario. Fixes robfig#205
this makes it possible to use cron with key/value logging systems.
BREAKING: WithVerboseLogger was changed to WithLogger.
Callers should update by invoking:
WithLogger(VerbosePrintfLogger(logger))
WithVerboseLogger was introduced in the most recent commit, so it's unlikely to
affect many users.
Fixes robfig#202
with cross-cutting concerns These JobWrappers are provided: - SkipIfStillRunning skips a job if the previous invocation is still running. - DelayIfStillRunning blocks a job invocation until the previous one is done. - Recover, to recover from panics in the job. BREAKING: This removes the default behavior of recovering from job panics. That must now be opted-into using WithChain(Recover(logger)). Having it be the default behavior can be surprising (see issue robfig#192) and is at odds with most libraries. Fixes robfig#191 Fixes robfig#192
Fix a typo in README
remove redundant asterisk in example
docs: remove redundant asterisk in example
Let cron depend on interface for parsers instead of fixed parser
Fix changing quartz scheduler site link for README
It was an error in channel scoping that was identified in pull robfig#263. This adds a unit test to identify that issue and verify the fix.
Add a special character 'L' in the day-of-month field, which specifies the last day of the month e.g: '0 0 18 L * ?' denotes the following: At 6:00:00PM, on the last day of the month, every month
Add support for Last Day of Month ('L')
Update module path
Pull in changes from master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.