-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text in IC log disappears when using <hahaha> #221
Comments
Problem's likely origin is from the 17th July (KFO update 4 related?). Didn't seem to have this problem on the 16th when I was recording. First noted it on the 23rd (July again) |
17th of August @GeckBluntBlade? |
Was this fixed in be4b6e7? |
@oldmud0 I believe this was discovered on the Release Day version of AO2, unless it updated since then it should be still present I think, |
oh this is specifically for the ic log |
Could not reproduce |
Reopening because of a breakthrough in investigation: this only seems to happen when log_goes_downwards tick is OFF. Might be an issue associated with the shitty way IC logs are written aka duplicate code. |
…t (optimization meme) Clear the IC log when log_colors setting changes and reload theme is pressed Fix AttorneyOnline#221
Turns out this was actually caused by disabling colors in IC log |
* Rewrite the IC Log code to drastically reduce code duplication and have both downward and upward mode in the same function Regenerate the IC Log in set_widgets() function, making sure the maximum_blocks is accounted for and clearing the log to prepare for different log mode (upwards/downwards) if it's different from previous Add placeholder text telling the user the direction in which the log will go Remove useless first_message_sent global boolean, a remnant from a w e a k e r c o d e r m a n * Add log_colors boolean to reduce color I/O happening in append_ic_text (optimization meme) Clear the IC log when log_colors setting changes and reload theme is pressed Fix #221 * Add configurable margin between IC log entries Add configurable newline/singleline log mode Options in settings for these * Add optional timestamps * Un-hardcode "played music" from the chatlogpiece and introduce the "action" argument so that "presented evidence" is fully supported now Translate "has presented evidence" Regenerate IC chatlog instead of clearing it, properly updating every element with the new configurations * Go away *temp, code duplication making me shid and cry rn Why is this not done in append_ic_text, or why isn't there a dedicated ic logging func aAAAaaaaAAAaa Fix presenting evidence not being properly logged Fix timestamp being UTC instead of local time (local time will not be as confusing) * okok it was a joke a big ol bamboozle you got gnomed haha rick rolled beaned stickbugged I did NOT copy paste code, no, I actually intended to fix copy pasted code all along. log_ic_text was always planned. (Fix copypasted code for ic_chatlog_history and consolidate it into a single log_ic_text func)
Resolve AttorneyOnline#221 and a non-issued bug that would prevent the chat from ever progressing
Does not happen on my end, only one user has reported this issue so far. Log goes downwards/upwards does not seem to affect this.
The text was updated successfully, but these errors were encountered: