Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TCP entry point #1007

Merged
merged 4 commits into from
Jul 9, 2024
Merged

Remove TCP entry point #1007

merged 4 commits into from
Jul 9, 2024

Conversation

TrickyLeifa
Copy link
Contributor

Resolve #987

  • Remove TCP entry point
    • Servers that do not support WebSocket will be marked as Legacy
    • Removal of TCP connection from the master will follow later.

Resolve #987

* Remove TCP entry point
  * Servers that do not support WebSocket will be marked as `Legacy`
  * Removal of TCP connection from the master will follow later.
@TrickyLeifa
Copy link
Contributor Author

deprecation-tcp
As mentioned, example of the marking.

@Salanto
Copy link
Contributor

Salanto commented Jul 7, 2024

Maybe we should reword this tooltip more for the end user? Most people will have no clue what a websocket entry point is.
Something like "Unable to connect to server due to missing WebSocket support"?

@TrickyLeifa
Copy link
Contributor Author

Sure.

TrickyLeifa added a commit to AttorneyOnline/akashi that referenced this pull request Jul 7, 2024
Copy link
Contributor

@Salanto Salanto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hee-Hoo pilled.

@Salanto Salanto merged commit efd2571 into master Jul 9, 2024
3 checks passed
@Salanto Salanto deleted the tcp-removal branch July 9, 2024 11:07
Salanto added a commit to AttorneyOnline/akashi that referenced this pull request Jul 14, 2024
* Removed TCP server

Resolve AttorneyOnline/AO2-Client#987, resolve AttorneyOnline/AO2-Client#1007

* Remove ini key, remove obsolete test

---------

Co-authored-by: Salanto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate TCP in favor of WebSocket
3 participants