-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More accurate/consistent blip rate functionality + punctuation slowdown fixes #305
More accurate/consistent blip rate functionality + punctuation slowdown fixes #305
Conversation
Remove qElapsedTimer method of blip earrape protection due to major inconsistency issues with this method (the same message would produce wildly different blip sounds - consistency is preferred) More sophisticated blip earrape prevention is calculated in the chat ticker function itself, it also properly adjusts itself depending on the blip_rate used.
Instant text using }}} is not only meme-worthy in how limited it is in practice, it also makes the blip ticker completely confused how and when to play the blips (to make instant text possible, the entire system needs rewriting (again)
As per recent commits, this PR also fixes punctuation slowdown-related shenanigans resulting in fixing a worse user experience. |
ok PLEASE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well-commented, good change, very epic
// where ! is the blip sound | ||
int b_rate = blip_rate; | ||
// Earrape prevention without using timers, this method is more consistent. | ||
if (msg_delay != 0 && msg_delay <= 25) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this arbitrary number 25? Is it just message_display_speed[2]
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something like that, it's a fine-tuned number I got to obtain the least earrapey result
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. Epic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like this is trying to be even more faithful. That's pretty ebin.
Changed the filter server buttons
Inspired by https://youtu.be/Min0hkwO43g
Here's what happens before this PR:
The third blip sound was skipped entirely because it landed on a whitespace, leading to blip sounds feeling slower than they actually are.
This fixes it by delaying the blip until the whitespace has been passed, leading to this result:
Meaning you hear 4 blips as intended, and removing the illusion of "slower text" caused by the difference.
Snapshots from the video used as reference:
Labelled as bug due to unintended consequence of a shoddy implementation.