More accurate/consistent blip rate functionality + punctuation slowdown fixes #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crystalwarrior
added
bug
Remove qElapsedTimer method of blip earrape protection due to major inconsistency issues with this method (the same message would produce wildly different blip sounds - consistency is preferred) More sophisticated blip earrape prevention is calculated in the chat ticker function itself, it also properly adjusts itself depending on the blip_rate used.
Instant text using }}} is not only meme-worthy in how limited it is in practice, it also makes the blip ticker completely confused how and when to play the blips (to make instant text possible, the entire system needs rewriting (again)
Crystalwarrior
changed the title
|
As per recent commits, this PR also fixes punctuation slowdown-related shenanigans resulting in fixing a worse user experience. |
|
ok PLEASE |
in1tiate
approved these changes
Nov 9, 2020
oldmud0
reviewed
Nov 10, 2020
| // where ! is the blip sound | ||
| int b_rate = blip_rate; | ||
| // Earrape prevention without using timers, this method is more consistent. | ||
| if (msg_delay != 0 && msg_delay <= 25) { |
There was a problem hiding this comment.
What is this arbitrary number 25? Is it just message_display_speed[2]?
There was a problem hiding this comment.
Something like that, it's a fine-tuned number I got to obtain the least earrapey result
oldmud0
approved these changes
Nov 10, 2020
lambdcalculus
pushed a commit
to lambdcalculus/AO2-Client
that referenced
this pull request
Jun 2, 2024
Changed the filter server buttons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by https://youtu.be/Min0hkwO43g
Here's what happens before this PR:
The third blip sound was skipped entirely because it landed on a whitespace, leading to blip sounds feeling slower than they actually are.
This fixes it by delaying the blip until the whitespace has been passed, leading to this result:
Meaning you hear 4 blips as intended, and removing the illusion of "slower text" caused by the difference.
Snapshots from the video used as reference:
Labelled as bug due to unintended consequence of a shoddy implementation.