Update the Settings screen - reload theme, restore defaults #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…by and courtroom)
…tings screen Add a "restore to defaults" option that allows you to restore all the configuration to its default values. Set up a .temp settings file that allows you to undo the effects of restoring default options.
Crystalwarrior
added
enhancement
in1tiate
approved these changes
Feb 11, 2021
oldmud0
reviewed
Feb 11, 2021
Comment on lines
+984
to
+988
| QFile::rename(ao_app->get_base_path() + "config.ini", ao_app->get_base_path() + "config.temp"); | ||
| // Load up the default settings | ||
| ao_app->configini->clear(); | ||
| // Update the values on the settings ui | ||
| update_values(); |
There was a problem hiding this comment.
Sounds complicated. You just want to read an empty file for QSettings, right? Perhaps read config.temp, update values, and delete the file right away.
There was a problem hiding this comment.
That's what I tried but QSettings behavior overwrote the file lol
There was a problem hiding this comment.
No but like delete the qsettings instance right after reading.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two new buttons - Reload Theme and Restore Defaults
Reload Theme button works even in lobby
Restore Defaults will rename the config.ini to config.temp and initialize the default values.
If the user presses "Cancel", the .temp file is reinstated as the config.ini file.
This also slightly overhauls the code for settings, moving all the funcs that set the checkbox values etc. into its own update_values() func
PR is tested, seems to be working just fine
Closes #454