-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Midi music #614
Midi music #614
Conversation
actually there is 1 issue, the CI failed for some reason |
Where does it load a soundfont from? Does it sound remotely good? |
what about .mod, .xm, .it etc. |
same filename but with soundfont ending, is handled by bass
depends on the midi+soundfont really, it ranges from poop midi to better than DS for AA music
bass already supports those without a plugin |
If bass supports it ao doesn't atm |
tested and working with echoing.mod and milky.xm it just shows missing file but i can't really tell why |
Missing file checker tests if the file exists using the file path for the music file, it's probably wacky in some silly way |
can i get a review pls |
else | ||
newstream = BASS_StreamCreateURL(f_path.toStdString().c_str(), 0, streaming_flags, nullptr, 0); | ||
|
||
} else { | ||
if (f_path.endsWith(".opus")) | ||
newstream = BASS_OPUS_StreamCreateFile(FALSE, f_path.utf16(), 0, 0, flags); | ||
else if (f_path.endsWith(".mid")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you didn't add .midi
i haven't found any issues with this