Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Midi music #614

Merged
merged 10 commits into from
Mar 25, 2022
Merged

Midi music #614

merged 10 commits into from
Mar 25, 2022

Conversation

stonedDiscord
Copy link
Member

i haven't found any issues with this

@stonedDiscord
Copy link
Member Author

actually there is 1 issue, the CI failed for some reason

@oldmud0
Copy link
Member

oldmud0 commented Dec 9, 2021

Where does it load a soundfont from? Does it sound remotely good?

@Crystalwarrior
Copy link
Contributor

what about .mod, .xm, .it etc.

@stonedDiscord
Copy link
Member Author

stonedDiscord commented Dec 24, 2021 •
edited
Loading

Where does it load a soundfont from?

same filename but with soundfont ending, is handled by bass

Does it sound remotely good?

depends on the midi+soundfont really, it ranges from poop midi to better than DS for AA music

what about .mod, .xm, .it etc.

bass already supports those without a plugin

@Crystalwarrior
Copy link
Contributor

Where does it load a soundfont from?

same filename but with soundfont ending, is handled by bass

Does it sound remotely good?

depends on the midi+soundfont really, it ranges from poop midi to better than DS for AA music

what about .mod, .xm, .it etc.

bass already supports those without a plugin

If bass supports it ao doesn't atm

@stonedDiscord
Copy link
Member Author

stonedDiscord commented Dec 24, 2021 •
edited
Loading

tested and working with echoing.mod and milky.xm

it just shows missing file but i can't really tell why

@Crystalwarrior
Copy link
Contributor

Missing file checker tests if the file exists using the file path for the music file, it's probably wacky in some silly way

oldmud0
oldmud0 reviewed Feb 6, 2022
View reviewed changes
src/text_file_functions.cpp Outdated Show resolved Hide resolved
oldmud0
oldmud0 reviewed Feb 15, 2022
View reviewed changes
src/aoapplication.cpp Outdated Show resolved Hide resolved
src/aomusicplayer.cpp Show resolved Hide resolved
@stonedDiscord
Copy link
Member Author

can i get a review pls

@Crystalwarrior Crystalwarrior added this to the 2.10 milestone Mar 24, 2022
@Crystalwarrior Crystalwarrior merged commit e0c6712 into master Mar 25, 2022
oldmud0
oldmud0 reviewed Apr 14, 2022
View reviewed changes
src/aomusicplayer.cpp
else
newstream = BASS_StreamCreateURL(f_path.toStdString().c_str(), 0, streaming_flags, nullptr, 0);

} else {
if (f_path.endsWith(".opus"))
newstream = BASS_OPUS_StreamCreateFile(FALSE, f_path.utf16(), 0, 0, flags);
else if (f_path.endsWith(".mid"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you didn't add .midi

@Crystal2002 Crystal2002 mentioned this pull request May 11, 2022
Open
@in1tiate in1tiate deleted the midimusic branch July 18, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oldmud0 oldmud0 oldmud0 left review comments

@Crystalwarrior Crystalwarrior Crystalwarrior approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.10 Release candidate
Development

Successfully merging this pull request may close these issues.
3 participants
@stonedDiscord @oldmud0 @Crystalwarrior