Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change some default settings #839

Merged
merged 3 commits into from
Sep 6, 2022
Merged

Change some default settings #839

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
27db797
Make default config enable features for most cases except for Continu…
Crystalwarrior Aug 1, 2022
132a1f0
Default disable animated themes
Salanto Aug 22, 2022
863e4fe
Merge branch 'master' into default-enable-feature
stonedDiscord Sep 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/text_file_functions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ int AOApplication::get_default_suppress_audio()

int AOApplication::get_max_log_size()
{
int result = configini->value("log_maximum", 200).toInt();
int result = configini->value("log_maximum", 1000).toInt();
return result;
}

Expand Down Expand Up @@ -1075,7 +1075,7 @@ bool AOApplication::is_instant_objection_enabled()

bool AOApplication::is_desyncrhonized_logs_enabled()
{
QString result = configini->value("desync_logs", "false").value<QString>();
QString result = configini->value("desync_logs", "true").value<QString>();
return result.startsWith("true");
}

Expand Down Expand Up @@ -1141,13 +1141,13 @@ bool AOApplication::is_sticker_enabled()

bool AOApplication::is_continuous_enabled()
{
QString result = configini->value("continuous_playback", "true").value<QString>();
QString result = configini->value("continuous_playback", "false").value<QString>();
return result.startsWith("true");
}

bool AOApplication::is_category_stop_enabled()
{
QString result = configini->value("category_stop", "true").value<QString>();
QString result = configini->value("category_stop", "false").value<QString>();
return result.startsWith("true");
}

Expand Down Expand Up @@ -1238,7 +1238,7 @@ QString AOApplication::get_subtheme()
bool AOApplication::get_animated_theme()
{
QString result =
configini->value("animated_theme", "true").value<QString>();
configini->value("animated_theme", "false").value<QString>();
return result.startsWith("true");
}

Expand All @@ -1260,12 +1260,12 @@ bool AOApplication::get_player_count_optout()

bool AOApplication::get_sfx_on_idle()
{
return configini->value("sfx_on_idle", "false").value<QString>()
return configini->value("sfx_on_idle", "true").value<QString>()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break almost all pre-existing content and cause immense confusion among the existing player base, most of whom will go and turn it off anyway. I don't know why you're fixated on this, but you can just distribute a default settings file with your own server content instead of doing this. Please do not do this.

.startsWith("true");
}

bool AOApplication::get_evidence_double_click()
{
return configini->value("evidence_double_click", "true").value<QString>()
return configini->value("evidence_double_click", "false").value<QString>()
.startsWith("true");
}