Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode URL before streaming #926

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Encode URL before streaming #926

merged 1 commit into from
Nov 23, 2023

Conversation

lambdcalculus
Copy link
Contributor

Sometimes BASS fails to handle unencoded URLs (seems to happen on Linux), so let's give it the encoded URL.

in1tiate
in1tiate approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@in1tiate in1tiate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stonedDiscord stonedDiscord merged commit 0729b91 into AttorneyOnline:master Nov 23, 2023
3 of 5 checks passed
@lambdcalculus lambdcalculus deleted the url-fix branch November 29, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@in1tiate in1tiate in1tiate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lambdcalculus @in1tiate @stonedDiscord