Explicitly set sane line spacing #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wouldn't this work better if its part of the chatbox configuration? Some fonts may look a bit goofy when the spacing is too close. |
This solution automatically decides line spacing based on the font's metrics, i.e. it will never decide to space lines too close together, because the font's own metrics will prevent this |
Salanto
requested changes
Jun 18, 2024
src/courtroom.cpp
Outdated
| @@ -3299,6 +3299,14 @@ void Courtroom::initialize_chatbox() | |||
| ui_vp_message->move(ui_vp_message->x() + ui_vp_chatbox->x(), ui_vp_message->y() + ui_vp_chatbox->y()); | |||
| ui_vp_message->setTextInteractionFlags(Qt::NoTextInteraction); | |||
|
|
|||
| // For some reason, line spacing is done incorrectly unless we set it here. | |||
| QTextCursor textCursor = ui_vp_message->textCursor(); | |||
| QTextBlockFormat *newFormat = new QTextBlockFormat(); | |||
There was a problem hiding this comment.
Nevermind, looks like a memory leak.
Address memory leak
|
@in1tiate Please re-test if it still works as expected. It was confirmed by the author to be working correctly still. |
Salanto
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes absurdly bad line spacing on some user-provided fonts due to Qt's adherence to their values instead of using a sane default. Examples:
Before change:
After change:
Related to (but not an explicit solution for) #733.