Proxy Sessions #2285
Merged
Proxy Sessions #2285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like some feedback on these points:
There is an edge case that is worth considering:What if a player joins the server with the same username as the user that is switching server?Player A starts changing serverProxy sends the login message to mc-servermc-server process the message and within the next 5 seconds grants access to Player A based on nicknamePlayer B joins, with the same nickname as Player A, the mc-serverNow Player B got access to Player A account without even typing a command.An idea to avoid this could be to add Player A remote IP to the proxy message in order to restrict the accessThis PR is an improved version of #2276 and avoids tasks
Closes #2126