Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle metadata in the Ndr plugin and store arnold specific metadata #55

Closed
sirpalee opened this issue Nov 22, 2019 · 1 comment · Fixed by #1350
Closed

Handle metadata in the Ndr plugin and store arnold specific metadata #55

sirpalee opened this issue Nov 22, 2019 · 1 comment · Fixed by #1350
Labels
enhancement New feature or request ndr Related to USD Node or Shader Registry user Reported by a user

Comments

@sirpalee
Copy link
Contributor

We should handle arnold metadata and store additional information in the ndr plugins.

This include:

  • metadata on arnold nodes
  • metadata on arnold parameters
  • metadata storing the arnold type of the parameter (there are arnold types that map to the same sdf type)

Describe the solution you'd like
We need to extend ndr/utils.cpp to deal with metadata. Add additional USD metadata to store the raw arnold type on the primitives in the Usd Stage returned by NdrArnoldGetShaderDefs. And pass metadata to Usd in the Discovery and Parser plugins.
@sirpalee sirpalee added the enhancement New feature or request label Nov 22, 2019
@sirpalee sirpalee added the ndr Related to USD Node or Shader Registry label Nov 29, 2019
@sirpalee sirpalee changed the title [Ndr Plugin] Handle metadata in the Ndr plugin and store arnold specific metadata Handle metadata in the Ndr plugin and store arnold specific metadata Nov 29, 2019
@sirpalee sirpalee self-assigned this Nov 11, 2020
sirpalee added a commit to sirpalee/arnold-usd that referenced this issue Nov 12, 2020
@sirpalee
Passing type identifiers and enum options through sdr. Autodesk#55
51670fd
@jhodgson jhodgson added the user Reported by a user label Mar 12, 2021
@JGamache-autodesk
Copy link

For reference: MaterialX metadata transfer to Sdr has been submitted as PixarAnimationStudios/OpenUSD#1895 following discussions in PixarAnimationStudios/OpenUSD#1874.

sebastienblor added a commit to sebastienblor/arnold-usd that referenced this issue Nov 14, 2022
@sebastienblor
Declare metadatas in Sdr registry Autodesk#55
d575886
@sebastienblor sebastienblor mentioned this issue Nov 14, 2022
Merged
sebastienblor added a commit that referenced this issue Nov 19, 2022
@sebastienblor
Improvements in the Sdr metadatas #55
8cb2d9c
sebastienblor added a commit to sebastienblor/arnold-usd that referenced this issue Nov 22, 2022
@sebastienblor
Fix typo in the comments Autodesk#55
b96ef16
sebastienblor added a commit that referenced this issue Nov 22, 2022
@sebastienblor
Declare metadatas in Sdr registry (#1350)
e1fac57 
* Declare metadatas in Sdr registry #55

* Improvements in the Sdr metadatas #55

* Fix typo in the comments #55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request ndr Related to USD Node or Shader Registry user Reported by a user
Projects
Arnold USD
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Declare metadatas in Sdr registry sebastienblor/arnold-usd
3 participants
@sirpalee @jhodgson @JGamache-autodesk