report legacy admin teams #104
Conversation
We split the content of certain table cells and link to individual GitHub entities within them if the column has a known type (e.g. users). If we don't recognize the column, then we should use the content as is.
docs/_data/navigation.yml
Outdated
| - title: "Tokenless Authentication" | ||
| url: "/recommendations-tokenless-auth" | ||
| - title: "Legacy Teams" | ||
| url: "/recommendations-teams-legacy" |
There was a problem hiding this comment.
I’d have named the URL recommendations-legacy-teams. I think that we wanted to have the navigation title (here, Recommendations) as the first component of the URL and have the rest match the subnavigation title (here, Legacy Teams).
Maybe, we should consider moving all the pages belonging to a navigation item into a subdirectory. In this way, the URLs would automatically be in the form /recommendations/legacy-teams, and this might make naming the URLs more consistent.
| @@ -520,7 +520,7 @@ function createTable(table) | |||
|
|
|||
| break; | |||
| default: | |||
| cell.text(entry); | |||
| cell.text(d); | |||
There was a problem hiding this comment.
That makes sense, thanks for fixing this!
| @@ -1,7 +1,7 @@ | |||
| --- | |||
| layout: default | |||
| title: Recommendations | |||
| permalink: /recommendations | |||
| permalink: /recommendations-tokenless-auth | |||
There was a problem hiding this comment.
Just a note not to forget renaming the permalink should we change it above 🙂.
updater/reports/ReportTeamsLegacy.py
Outdated
| # Organizations created before September 2015 might have legacy admin | ||
| # teams. In order to get the best performance out of GHE, these teams | ||
| # should be migrated to the improved permissions model. | ||
| # c.f.ghttps://help.github.com/enterprise/2.11/user/articles/migrating-your-previous-admin-teams-to-the-improved-organization-permissions/ |
There was a problem hiding this comment.
There seems to be an issue with c.f.ghttps. Looks like the g was intended to be a space character?
larsxschneider
force-pushed
the
lars/legacy-teams
branch
from
f4069fe
to
92dfa73
Compare
|
@larsxschneider: Wait, I think you forgot to add the HTML file 😅. |
Organizations created before September 2015 might have legacy admin teams. In order to get the best performance out of GitHub Enterprise, these teams should be migrated to the improved permissions model. Report the affected teams in a new dashboard.
I recommend to review the PR commit by commit: