Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove inline JavaScript from header and replace it with Jekyll directive #18

Merged
merged 9 commits into from
Oct 16, 2017
Merged

Remove inline JavaScript from header and replace it with Jekyll directive #18

Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
327e881
Update default.html
Swardu Oct 15, 2017
e1d28b2
Update default.html
Swardu Oct 15, 2017
393837b
Update default.html
Swardu Oct 15, 2017
454e125
Update default.html
Swardu Oct 15, 2017
4c6eda1
Update default.html
Swardu Oct 15, 2017
2c9a86f
Update default.html
Swardu Oct 15, 2017
cef175c
Update default.html
Swardu Oct 15, 2017
b187702
Update default.html
Swardu Oct 15, 2017
22c0dd8
Update default.html
Swardu Oct 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/_layouts/default.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
</a>
<a href="{{ site.baseurl }}/" alt="Hubble Enterprise">
<img src="{{ site.baseurl }}/assets/images/logo-title.svg" class="project-logo" width="3rem" height="3rem">
<h1 class="project-name"><script type="text/javascript">document.write(gheHostname())</script> Statistics</h1>
<h1 class="project-name">{{ site.url | remove: "http://", "https://" }} Statistics</h1>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get this error with Jekyll 3.3.1 locally:

  Liquid Exception: Liquid error (line 38): wrong number of arguments (given 3, expected 2) in /_layouts/default.html

Any idea what to do about it?

Copy link
Contributor Author

@Swardu Swardu Oct 15, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like "remove" only supports 1 argument, there doesn't seem to be another way on the Jekyll docs. We can try using both "remove" and "remove_first".

</a>
</section>
{% include navigation.html %}
Expand Down