Collaboration chart: draw chosen org first, make first org blue #31
Conversation
docs/assets/js/charts.js
Outdated
| ]; | ||
|
|
||
| function extendedChartColor(i) | ||
| { | ||
| return extendedChartColors[(i + 3) % extendedChartColors.length]; | ||
| return extendedChartColors[i % extendedChartColors.length]; |
There was a problem hiding this comment.
@pluehne I think this addition has no other purpose than rotating the color wheel, right?
There was a problem hiding this comment.
Exactly, and it shouldn’t be in the code.
pluehne
changed the title
|
@larsxschneider: I agree that it looks better to start with blue. Also, I think you have a good point with changing the order of the colors in general, because I realize that the first few colors are quite similar, making it hard to differentiate them in the single organization views. For this reason, I opened a separate pull request #32, which also starts with blue but then selects more contrasting colors. Sorry for repeating parts of what you did in this pull request! |
|
Aside from this, I like the idea to make the selected organization blue in all cases very much. Maybe have a look at my other pull request, and after that let’s merge this one! |
If the collaboration chart of a single organization is visualized, then ensure that the choosen org is always drawn first. This way the choosen org is always drawn with the same color. In addition, rotate the color wheel to start with the color "blue" because I think it looks good.
larsxschneider
force-pushed
the
single-org-color
branch
from
cfd3dc6
to
11aa7d6
Compare
If the collaboration chart of a single organization is visualized, then
ensure that the choosen org is always drawn first. This way the choosen
org is always drawn with the same color.
In addition, rotate the color wheel to start with the color "blue"
because I think it looks good.