List: organization owners #36
Conversation
* This was Patrick's reverse engineering efforts
* We may have a ghe-console script from GitHub support
(https://support.enterprise.github.com/hc/en-us/requests/51994)
* We need to remove service accounts
* scaffolding for showing the above results
|
I recreated your files in my (older Hubble) dev env and ran into a file generation problem. The error was:
So, in ReportOrgOwners.py, I changed this
to this
Now the data file is built. My output, though, is a table 10,221 rows long. There is one owner per line and took about 24 seconds to build. |
|
@toddocon I fixed the ghe-console script (thank you GHE support!) |
|
I'm not sure why you need to specify 'scripts' and I don't. |
|
@toddocon: It’s weird that self.executeScript(self.scriptPath("org-owners.sh"))didn’t work for you, but self.executeScript(os.path.join("scripts", "org-owners.sh"))did. In fact, Also, other reports (such as for Git versions) use the same call. Are they broken for you as well? |
There was a problem hiding this comment.
@mlbright: Your changes look good to me 😃. I listed some tiny details below.
We’ll also need some demo data for the interactive web demo.
And, similar to what @toddocon mentioned, it would be better to have all the owners of each organization on the same output line.
I can help with all that, just give me write access to your branch 😃.
docs/org-owners.html
Outdated
| permalink: /org-owners | ||
| --- | ||
| <h3> | ||
| Organization owners |
There was a problem hiding this comment.
@mlbright: Can you make this title case (“Organization Owners”)?
updater/update-stats.py
Outdated
| @@ -21,6 +21,7 @@ | |||
| from reports.ReportRepositoryHistory import * | |||
| from reports.ReportTokenlessAuth import * | |||
| from reports.ReportUsers import * | |||
| from reports.ReportOrgOwners import * | |||
There was a problem hiding this comment.
@mlbright: Could you please sort these alphabetically?
updater/update-stats.py
Outdated
| @@ -82,6 +83,7 @@ def main(): | |||
| ReportRepositoryHistory(configuration, dataDirectory, metaStats).update() | |||
| ReportTokenlessAuth(configuration, dataDirectory, metaStats).update() | |||
| ReportUsers(configuration, dataDirectory, metaStats).update() | |||
| ReportOrgOwners(configuration, dataDirectory, metaStats).update() | |||
There was a problem hiding this comment.
@mlbright: Could you please sort these alphabetically?
|
For future versions of this report, I’d like the following improvements:
But for now, I think this report is already very useful 😃. |
docs/org-owners.html
Outdated
| <div class="row"> | ||
| <div class="col-main"> | ||
| <div class="chart-container"> | ||
| <table class="table" data-url="{{ site.dataURL }}/org-owners.tsv"></table> |
There was a problem hiding this comment.
@mlbright: You accidentally mixed spaces and tabs here.
docs/org-owners.html
Outdated
| </div> | ||
| <div class="col-main"> | ||
| <div class="chart-container"> | ||
| <table class="table" data-url="{{ site.dataURL }}/org-owners.tsv"></table> |
There was a problem hiding this comment.
Sorry, I should have been more specific. We’re using tabs in the other report files, and it would be best to keep that consistent.
|
As I don’t have write access to @mlbright’s branch, I branched this pull request. 7e9ce8d adds some demo data for autodesk.github.io, and be7a159 is a work-in-progress commit, where I started to support multiple owner names on a single line in the table (with links to their GitHub profiles). I left this work-in-progress, as I’ll be out of office until next week. Note that the updater report’s output format needs to be changed in the same way (instead of having one line for each (organization, owner) pair, just output a single line for each organization with all the owners comma-separated). Also, the column heading should be owners and not owner (singular). |
|
Superseded by #38 |
(https://support.enterprise.github.com/hc/en-us/requests/51994)