fix executeGHEConsole() / ReportOrgOwners for Hubble service #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsxschneider
force-pushed
the
fix/ghe-console
branch
from
5dddbad
to
3685c8f
Compare
pluehne
approved these changes
Nov 20, 2017
larsxschneider
force-pushed
the
fix/ghe-console
branch
from
3685c8f
to
8aaf3e6
Compare
pluehne
reviewed
Nov 20, 2017
updater/reports/Report.py
Outdated
| if not stdin: | ||
| # A script is either a path to a file or a list of strings | ||
| # with bash commands. Both are executed by passing the script | ||
| # to stdin to `bash -s --`. This method only works if we habve |
pluehne
reviewed
Nov 20, 2017
updater/reports/Report.py
Outdated
| except: | ||
| command = script | ||
| if not stdin: | ||
| # A script is either a path to a file or a list of strings |
There was a problem hiding this comment.
Maybe we should put this explanation in the comment above executeScript so that this is immediately clear when reading the function? And I wouldn’t mind having this information here as well.
The executeGHEConsole() function (and consequently the ReportOrgOwners) was broken if Hubble is configures as service that runs on the GitHub Enterprise appliance. Fix it.
larsxschneider
force-pushed
the
fix/ghe-console
branch
from
8aaf3e6
to
1442407
Compare
pluehne
approved these changes
Nov 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The executeGHEConsole() function (and consequently the ReportOrgOwners)
was broken if Hubble is configures as service that runs on the GitHub
Enterprise appliance. Fix it.