Switch updater to systemd system service #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsxschneider
approved these changes
Jan 3, 2018
| @@ -72,7 +72,7 @@ The updater may be run in two modes: | |||
|
|
|||
| The updater’s log is accessible as follows: | |||
| ```sh | |||
| journalctl -f --user-unit hubble-enterprise.service | |||
| journalctl -fu hubble-enterprise.service | |||
There was a problem hiding this comment.
this change is unrelated, right?
There was a problem hiding this comment.
No, it isn’t. -u stands for --unit and refers to system units, while --user-unit is the equivalent for user units and doesn’t have a corresponding shorthand option.
| @@ -2,7 +2,7 @@ all: # nothing to build | |||
|
|
|||
| PKGNAME = hubble-enterprise | |||
| INSTALLDIR = $(DESTDIR)/opt/autodesk/$(PKGNAME) | |||
| SYSTEMDDIR = $(DESTDIR)/home/admin/.local/share/systemd/user | |||
| SYSTEMDDIR = $(DESTDIR)/usr/lib/systemd/system | |||
There was a problem hiding this comment.
Do you see a way to move our stuff into a subdirectory here? Would that make sense?
There was a problem hiding this comment.
I think that systemd doesn’t look for unit files in a subdirectory.
This makes the systemd system service a user service. There are two reasons that motivated this change. First, user services require an active session of the specified user. This has the drawback that the updater would not be triggered after reboots if no SSH connection to the GitHub Enterprise appliance was made. Second, user services cannot depend on system services. Because of that, the updater service could not reliably wait for the rest of GitHub Enterprise to start.
pluehne
force-pushed
the
patrick/system-service
branch
from
4a812d6
to
5d5b79a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the
systemdsystem service a user service. There are two reasons that motivated this change.