Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection of a ProxyShape will select individual prims in the hierarchy in VP2.0 #262

Closed
dj-mcg opened this issue Feb 7, 2020 · 5 comments
Assignees
Labels
bug Something isn't working vp2renderdelegate Related to VP2RenderDelegate

Comments

@dj-mcg
Copy link
Collaborator

dj-mcg commented Feb 7, 2020

Describe the bug
When selecting a ProxyShape object in Viewport 2.0, a subset of prims in the ProxyShape hierarchy are often selected rather than the entire ProxyShape itself. While there may be workflows where this behavior is helpful, the default behavior should be that the entire Proxy Shape is selected.

Steps to reproduce
Steps to reproduce the behavior:

  1. Run the testPorxyShapeSelectionPerformance test. Observe the failed assert

Expected behavior
The test passes with no errors.

Additional context
This test is part of a suite of tests that are run internally at Pixar. They are not included run as part of the external Pixar usdMaya plugin tests since they are making assumptions about the runtime environment that may not be valid for all users. However, moving forward, these tests should be run internally within Autodesk to validate correctness when testing any changes or fixes to the usdMaya plugin.

@dj-mcg dj-mcg added the bug Something isn't working label Feb 7, 2020
@kxl-adsk
Copy link

The described bug is actually expected behavior. We enable native workflows on USD data and selection is the foundation for many of them.

It sounds like for your workflows, you would like to have control over selection behavior, i.e USD prim vs DG Shape.

@kxl-adsk
Copy link

kxl-adsk commented Mar 2, 2020

@mattyjams assigned this issue to you since you have open PR for it.

@kxl-adsk kxl-adsk added the vp2renderdelegate Related to VP2RenderDelegate label Mar 2, 2020
@santosg87
Copy link
Collaborator

Hi @dj-mcg can this one be closed, since the PR was merged on #315

@dj-mcg
Copy link
Collaborator Author

dj-mcg commented Mar 23, 2020 via email

@mattyjams
Copy link
Contributor

Yup, we addressed this with the changes in #315. Ok to close, thanks @santosg87!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working vp2renderdelegate Related to VP2RenderDelegate
Projects
None yet
Development

No branches or pull requests

4 participants