[tests] interactive tests ensure output streams are flushed before quitting #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One note - it seems I had my editor's option to automatically strip trailing whitespace on when I was making these changes. There's not too many of them, though, so hopefully it isn't too confusing. If you feel it is, I can separate out the whitespace changes. |
kxl-adsk
approved these changes
Dec 22, 2020
|
LGTM but since most of the latest interactive tests were added by @mattyjams, I would like to make sure it works for him too. |
kxl-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When developing #915, we uncovered an issue where output streams weren't being flushing before interactive maya tests quit.
This applies the fix developed in that PR to all interactive maya tests, so we can be sure to see all their output on stdout.