MAYA-108709 undoable command base class. #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pierrebai-adsk
commented
Mar 1, 2021
pierrebai-adsk
commented
- Simple undoable command base class.
- Only handle the UsdUndoableItem.
- Only supports non-interactive commands.
- Used in the matrix non-interactive commands.
- Simple undoable command base class. - Only handle the UsdUndoableItem. - Only supports non-interactive commands. - Used in the matrix non-interactive commands.
Strangely, the format is bad on lines i did not touch...?
|
Not the first time I get caught on lines failing the clang format linter on lines I haven't touched...! |
ppt-adsk
reviewed
Mar 1, 2021
kxl-adsk
approved these changes
Mar 3, 2021
kxl-adsk
added
ready-for-merge
ppt-adsk
approved these changes
Mar 4, 2021
ppt-adsk
approved these changes
Mar 4, 2021
|
Ah sorry, my editor applies pep8 automatically on Python files... |
kxl-adsk
added
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.