MAYA-110155: consistent namespace across the project - Part 2 #1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HamedSabri-adsk
commented
Mar 3, 2021
HamedSabri-adsk
commented
- colorSpace
- blockSceneModificationContext
HamedSabri-adsk
commented
Mar 3, 2021
| @@ -19,16 +19,22 @@ | |||
|
|
|||
| PXR_NAMESPACE_USING_DIRECTIVE | |||
There was a problem hiding this comment.
Forced to keep this here because of "PIXMAYA_LINEAR_COLORS"
ppt-adsk
approved these changes
Mar 3, 2021
HamedSabri-adsk
added
the
ready-for-merge
kxl-adsk
suggested changes
Mar 16, 2021
lib/mayaUsd/nodes/hdImagingShape.cpp
Outdated
| @@ -207,7 +207,7 @@ MObject PxrMayaHdImagingShape::GetOrCreateInstance() | |||
| // We never intend for the imaging shape to get saved out to the Maya scene | |||
| // file, so make sure that we preserve the scene modification status from | |||
| // before we create the shape. | |||
| const UsdMayaBlockSceneModificationContext blockModContext; | |||
| const MayaUsd::utils::UsdMayaBlockSceneModificationContext blockModContext; | |||
There was a problem hiding this comment.
Simply a reminder of internal discussion - let's remove the UsdMaya prefix since it's not very useful when the class now lives in the proper namespace.
kxl-adsk
removed
the
ready-for-merge
kxl-adsk
approved these changes
Mar 21, 2021
|
@HamedSabri-adsk please resolve merge conflicts and trigger a PF. |
HamedSabri-adsk
added
the
ready-for-merge
kxl-adsk
deleted the
sabrih/MAYA-110155/consistent_namespace_across_lib_part_2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.